feat: Always redirect to language that was saved in cookie #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that after first visit, when we detect browser language and
store locale cookie, we reuse that cookie and re-set language during
navigation. Before this change, even with `alwaysRedirect` enabled, we
have only redirected on first visit and on next visits user got default
language again.
Changes:
- Don't base ability to set client-side cookies on the `isSpa` flag.
That flag signified whether app was in 'spa' mode (another possible
mode is 'universal') and it only allowed setting client-side cookies
in that mode. That's wrong as it should also be possible to set
client-side cookies when running on client side in 'universal' mode.
Use `process.client` and `process.server` instead, which are more
appropriate flags to check for that purpose.
- Expose setLocaleCookie on `app.i18n` (`this.$i18n` in components)
as we need to be able to call it manually after changing locale
in custom language selector.
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 4 4
=====================================
Hits 4 4Continue to review full report at Codecov.
|
paulgv
changed the title
|
Thanks @rchl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that after first visit, when we detect browser language and
store locale cookie, we reuse that cookie and re-set language during
navigation. Before this change, even with
alwaysRedirectenabled, wehave only redirected on first visit and on next visits user got default
language again.
Changes:
isSpaflag.That flag signified whether app was in 'spa' mode (another possible
mode is 'universal') and it only allowed setting client-side cookies
in that mode. That's wrong as it should also be possible to set
client-side cookies when running on client side in 'universal' mode.
Use
process.clientandprocess.serverinstead, which are moreappropriate flags to check for that purpose.
app.i18n(this.$i18nin components)as we need to be able to call it manually after changing locale
in custom language selector.