fix: remove explicit dependency on vue-template-compiler (fixes #297) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't have explicit dependency as that package requires its and vue's versions to match exactly and we can't ensure that. Remove it and just make sure that this dependency is only used on building nuxt app (done before already, just added more explanation in comments).
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 4 4
=====================================
Hits 4 4Continue to review full report at Codecov.
|
paulgv
approved these changes
May 13, 2019
pi0
approved these changes
May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't have explicit dependency as that package requires its and vue's
versions to match exactly and we can't ensure that. Remove it and just
make sure that this dependency is only used on building nuxt app (done
before already, just added more explanation in comments).