Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move SEO types out of Vue module declaration #335

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Conversation

paulgv
Copy link
Collaborator

@paulgv paulgv commented Jun 22, 2019

This follows up on the discussion here: #319 (comment)

rchl 22 days ago Member
I don't really know much about typescript or writing declaration files but should this interface be defined outside of the declare module block?

kevinmarrec 20 days ago Member
@rchl Is right, the interface definition should be before declaring module and not inside.

@paulgv
Copy link
Collaborator Author

paulgv commented Jun 22, 2019

@rchl Is this the right way to fix this?

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #335   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           6      6           
=====================================
  Hits            6      6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e046a5f...be085d5. Read the comment docs.

@paulgv paulgv requested a review from rchl June 22, 2019 13:22
Copy link
Collaborator

@rchl rchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say so, yes.

@paulgv paulgv merged commit 0cc0ba0 into master Jun 22, 2019
@paulgv paulgv deleted the move-seo-types branch July 13, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants