Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change seo option to false for next major version #346

Closed
rchl opened this issue Jul 2, 2019 · 3 comments
Closed

Change seo option to false for next major version #346

rchl opened this issue Jul 2, 2019 · 3 comments

Comments

@rchl
Copy link
Collaborator

rchl commented Jul 2, 2019 •
edited
Loading

What problem does this feature solve?

seo = true option is computationally expensive (https://nuxt-community.github.io/nuxt-i18n/seo.html#improving-performance), sometimes even breaks the code, and users typically don't need the functionality it provides and would be fine with using it the way the mentioned link describes.

What does the proposed changes look like?

I suggest change seo option to false by default, update documentation regarding that and suggest using solution from https://nuxt-community.github.io/nuxt-i18n/seo.html#improving-performance
Those who really need that functionality will be able to change the option to true.

This feature request is available on Nuxt community (#c256)
@ghost ghost added the cmty:feature-request label Jul 2, 2019
@paulgv
Copy link
Collaborator

paulgv commented Jul 2, 2019

Thanks @rchl, I think this makes sense. Would you have some time to open a PR by any chance?

This was referenced Jul 3, 2019
Merged
Closed
paulgv added a commit that referenced this issue Jul 13, 2019
@paulgv
Merge pull request #347 from rchl/feature/disable-seo
5403c56 
(for next major version!) Disable seo by default (fixes #346)
paulgv pushed a commit that referenced this issue Jul 13, 2019
@rchl @paulgv
fix: Disable seo by default
918ae89 
BREAKING CHANGE: Global seo option is now disabled by default. To
preserve the previous behaviour, set `seo: true` in the module's
options.
Doc: https://nuxt-community.github.io/nuxt-i18n/seo.html

fixes #346
paulgv pushed a commit that referenced this issue Jul 15, 2019
@rchl @paulgv
fix: Disable seo by default
5115b5b 
BREAKING CHANGE: Global seo option is now disabled by default. To
preserve the previous behaviour, set `seo: true` in the module's
options.
Doc: https://nuxt-community.github.io/nuxt-i18n/seo.html

fixes #346
@h-archer
Copy link

h-archer commented Jul 17, 2019 •
edited
Loading

Guys, THIS MUST BE ADDED IN THE NEXT VERSION!!!! I just waisted a WHOLE DAY trying to figure out why my already built website had major issues with my page styles breaking on page route changes because my body class style kept changing all of a sudden. I spent the whole day looking into things and resorted to changing my CSS to get it to work. Then realised what if it's something to do with nuxt-i18n because I installed it the previous day. Then I read this, and made seo:false, AND MY WEBSITE IS BACK TO NORMAL AGAIN!!!! (Yes i am extremely happy now!) Guys this is a bad design decision... Never force a setting on a user! Please disable in the next release!

@paulgv
Copy link
Collaborator

paulgv commented Jul 18, 2019

@hga77 That's the plan :) 5115b5b

paulgv pushed a commit that referenced this issue Jul 20, 2019
@rchl @paulgv
fix: Disable seo by default
ecb1584 
BREAKING CHANGE: Global seo option is now disabled by default. To
preserve the previous behaviour, set `seo: true` in the module's
options.
Doc: https://nuxt-community.github.io/nuxt-i18n/seo.html

fixes #346
@paulgv paulgv closed this as completed in 741ae12 Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rchl @h-archer @paulgv