Use default locale's custom path if not defined for a locale

[jeanphilippeds]

Hello,

Here is a PR to use default locale's custom path when a custom path is not defined for a locale.
It can help if you have a lot of locales to manage and only want a custom path for a few of them.

[codecov]

Codecov Report

Merging #354 into 6.x will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            6.x   #354   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         2      2           
  Lines         6      6           
===================================
  Hits          6      6

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95af03f...012345a. Read the comment docs.

[lmichelin]

the description seems to have been copy-pasted from the previous line 😕

[jeanphilippeds]

fixed 😜

[paulgv]

Thanks for the PR @jeanphilippeds.

This change makes sense to me but it should be considered as a breaking change. I've changed the base branch to 6.x and we'll release this in the next major version.

I left one small comment, could you address it before we merge this?

[rchl]

@jeanphilippeds I know this is an old PR but I've just stumbled upon the behavior introduced by this change and I do wonder how it does make sense...

When we have

• two locales: en and fr
• the default locale is fr
• we have an about.vue page for which we set custom path:

{
  'fr': '/about-fr'
}

With this change here the English locale will also use the about-fr name for the about page. This doesn't seem right to me.

Without this change, the en locale would use the about name.

Maybe the intention here was to handle a case like for example:

• three locales: en, fr, es
• the default locale is en
• only fr locale has overridden path:

{
  'fr': '/about-fr'
}

And then both the en and es locales default to about. That makes sense but that would also happen without this change. So I don't really get it.