Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): add option onDecode and onDecodeError #35

Merged
merged 1 commit into from
Mar 14, 2019
Merged

feat(module): add option onDecode and onDecodeError #35

merged 1 commit into from
Mar 14, 2019

Conversation

ricardogobbosouza
Copy link
Member

  • Move default options to rules to that not a have a breaking changes
  • Add option onDecode to decode url.
  • Add option onDecodeError to handle error on decode.

Resolves #11

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          24     33    +9     
  Branches        6      8    +2     
=====================================
+ Hits           24     33    +9
Impacted Files Coverage Δ
lib/middleware.js 100% <100%> (ø) ⬆️
lib/module.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d3f8b...51b644c. Read the comment docs.

@manniL
Copy link
Member

manniL commented Mar 14, 2019

Well done 👏

@manniL manniL merged commit 4000dc7 into nuxt-community:master Mar 14, 2019
@ricardogobbosouza ricardogobbosouza deleted the feat-decode branch March 20, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants