fix: crash on init with inline-style options #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 37 37
Branches 8 8
=====================================
Hits 37 37
Continue to review full report at Codecov.
|
manniL
reviewed
Aug 27, 2019
Module just crashed on parsing options when non-inline (this.options.redirect) options were not provided. While there was a test already that tested inline options, it didn't remove non-inline options from config object so it didn't fail.
rchl
force-pushed
the
fix/crash-on-merging-options
branch
from
ac52fc9
to
ae8eea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module just crashed on parsing options when non-inline
(this.options.redirect) options were not provided. While there was a
test already that tested inline options, it didn't remove non-inline
options from config object so it didn't fail.