Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename useMeta to useHead #135

Merged
merged 2 commits into from Apr 20, 2022
Merged

fix: rename useMeta to useHead #135

merged 2 commits into from Apr 20, 2022

Conversation

Intevel
Copy link
Contributor

@Intevel Intevel commented Apr 5, 2022

The useMeta property has been renamed to useHead. Without this change the module would be broken with the latest framework version.

Regarding to this: nuxt/framework#4066

danielroe
danielroe approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Intevel
Copy link
Contributor Author

Intevel commented Apr 7, 2022

Thanks for fixing the lint errors. @danielroe 💚

@danielroe
Copy link
Collaborator

danielroe commented Apr 7, 2022 •
edited

(The issue was that the version of nuxt3 originally in this PR didn't have a useHead export.)

@Intevel
Copy link
Contributor Author

Intevel commented Apr 19, 2022

@danielroe Any chance to merge this?

@danielroe danielroe merged commit 63d86ab into nuxt-modules:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Intevel @danielroe