Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to harlem v3 #226

Merged
merged 11 commits into from
Mar 28, 2023
Merged

feat: upgrade to harlem v3 #226

merged 11 commits into from
Mar 28, 2023

Conversation

Lexpeartha
Copy link
Contributor

PR to help move move onto the new Harlem version

@Lexpeartha
Copy link
Contributor Author

Lexpeartha commented Dec 20, 2022

Currently module crashes and window is not defined error is thrown. Tried experimenting by moving certain parts to app:beforeMount and app:mounted hooks, but that didn't cut it. Feeling stuck atm, would really appreciate help

@danielroe
Copy link
Contributor

Apologies for the lack of response! It's possible the issue is upstream in Harlem.

@Lexpeartha
Copy link
Contributor Author

Apologies for the lack of response! It's possible the issue is upstream in Harlem.

Hi, thanks for looking into this. Do you want me open an issue about this in the harlem repo then?

@Lexpeartha
Copy link
Contributor Author

@danielroe Now it's starting properly, however playground is stuck in endless loading. I suspect that it has something to do with client ssr plugin:

Failed to load url /@fs/home/aleksa/.nvm/versions/node/v16.17.1/lib/node_modules/@nuxt/devtools/dist/runtime/plugins/devtools.client.mjs?v=8bba95be (resolved id: /home/aleksa/.nvm/versions/node/v16.17.1/lib/node_modules/@nuxt/devtools/dist/runtime/plugins/devtools.client.mjs?v=8bba95be) in virtual:nuxt:/home/aleksa/Desktop/Projects/nuxt-harlem-module/playground/.nuxt/plugins/client.mjs. Does the file exist?

@danielroe
Copy link
Contributor

danielroe commented Mar 28, 2023

This seems to be working for me with/without devtools disabled - maybe it's not an issue with this module?

@Lexpeartha
Copy link
Contributor Author

Oops, seems I've forgot to disable devtools 😅
You're right tho, without them it seems to be working fine, so I think we can merge this for now and maybe tackle this possible devtool issue in separate PR

@Lexpeartha Lexpeartha marked this pull request as ready for review March 28, 2023 13:53
@danielroe danielroe changed the title chore: upgrade to harlem v3 feat: upgrade to harlem v3 Mar 28, 2023
@danielroe danielroe merged commit e17d43a into nuxt-modules:main Mar 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants