refactor!: vueI18n options from config path
#1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
commented
Apr 2, 2023
src/gen.ts
Outdated
| // }` | ||
| // genCodes += ` ${rootKey}.${key} = await ${optionLoaderVariable}(context)\n` | ||
| genCodes += ` ${rootKey}.${key} = ${vueI18nConfigPath != null ? 'vueI18nOptions' : {} }\n` | ||
| genCodes += ` if (${rootKey}.${key}.messages) { console.warn("[${NUXT_I18N_MODULE_ID}]: Cannot include 'messages' option in '${value}'. Please use Lazy-load translations."); ${rootKey}.${key}.messages = {}; }\n` |
There was a problem hiding this comment.
MEMO(TODO):
If we have messages options, we must pre-compile the resource using dynamic import & bundler (virtual module) at i18n.options.mjs (gen.ts). This is because, in production, vue-i18n assumes that the resource is pre-compiled.
7 tasks
|
Minor future task: allow configuration from |
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* docs: mention callbacks * chore: initial commit * chore: progress * chore: updating minor bits and tests * refactor!: `vueI18n` options from config path * fix: complete config load implementation * updates * fix: unit tests * fix: e2e testing * update lock file * tweak docs --------- Co-authored-by: Inesh Bose <2504266b@student.gla.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes #1948
❓ Type of change
📚 Description
ref: #1948
📝 Checklist