Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lazy load i18n files #2193

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix: lazy load i18n files #2193

merged 1 commit into from
Jul 3, 2023

Conversation

userquin
Copy link
Contributor

@userquin userquin commented Jul 2, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2192

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@userquin
Copy link
Contributor Author

userquin commented Jul 2, 2023 •
edited

Applying a pnpm patch on my local, it is working with single and multiple i18n files per locale:

imagen

This was referenced Jul 2, 2023
Closed
Closed
kazupon
kazupon approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM!

@kazupon kazupon merged commit 41c910c into nuxt-modules:next Jul 3, 2023
8 checks passed
@userquin userquin deleted the fix-lazy-load-files branch July 3, 2023 07:34
kazupon added a commit that referenced this pull request Jul 10, 2023
@kazupon
Revert "fix: lazy load i18n files (#2193)"
b7af310 
This reverts commit 41c910c.
This was referenced Jul 10, 2023
Merged
Closed
kazupon added a commit that referenced this pull request Jul 10, 2023
@kazupon
Revert "fix: lazy load i18n files (#2193)" (#2219)
8d65ac4 
This reverts commit 41c910c.
@userquin userquin mentioned this pull request Jul 10, 2023
Merged
7 tasks
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@userquin
fix: lazy load i18n files (nuxt-modules#2193)
40f948d
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@kazupon
Revert "fix: lazy load i18n files (nuxt-modules#2193)" (nuxt-modules#…
5de9e01 
…2219)

This reverts commit 41c910c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lazy load files not working
2 participants
@userquin @kazupon