feat: add ids for injected scripts (#333)

nuxt-modules · Dec 4, 2023 · 18addcf · 18addcf
1 parent 3e04bf4
commit 18addcf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/module.ts b/src/module.ts
@@ -75,15 +75,15 @@ export default defineNuxtModule<ModuleOptions>({
       nuxt2Options.head.__dangerouslyDisableSanitizersByTagID.partytown = ['innerHTML']
       nuxt2Options.head.__dangerouslyDisableSanitizersByTagID['partytown-config'] = ['innerHTML']
       nuxt2Options.head.script.unshift(
-        { hid: 'partytown-config', innerHTML: `partytown = ${renderedConfig}` },
-        { hid: 'partytown', innerHTML: partytownSnippet }
+        { id: 'partytown-config', hid: 'partytown-config', innerHTML: `partytown = ${renderedConfig}` },
+        { id: 'partytown', hid: 'partytown', innerHTML: partytownSnippet }
       )
     } else {
       // Use @vueuse/head syntax to inject scripts
       nuxt.options.app.head.script = nuxt.options.app.head.script || []
       nuxt.options.app.head.script.unshift(
-        { innerHTML: `partytown = ${renderedConfig}` },
-        { innerHTML: partytownSnippet }
+        { id: 'partytown-config', innerHTML: `partytown = ${renderedConfig}` },
+        { id: 'partytown', innerHTML: partytownSnippet }
       )
     }
 

diff --git a/test/e2e/module.spec.ts b/test/e2e/module.spec.ts
@@ -18,11 +18,11 @@ describe('module', () => {
 
   it('injects partytown config', async () => {
     const result = await $fetch('/')
-    expect(result).toContain('<script>partytown = { debug: false')
+    expect(result).toContain('<script id="partytown-config">partytown = { debug: false')
   })
 
   it('injects partytown script', async () => {
     const result = await $fetch('/')
-    expect(result).toContain('<script>/* Partytown')
+    expect(result).toContain('<script id="partytown">/* Partytown')
   })
 })