Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuetify preset module not applying custom variables #88

Closed
adamskeeled opened this issue Aug 17, 2020 · 5 comments
Closed

Vuetify preset module not applying custom variables #88

adamskeeled opened this issue Aug 17, 2020 · 5 comments
Labels
type: bug Something isn't working

Comments

@adamskeeled
Copy link

Version

@nuxtjs/storybook: v2.1.0
nuxt: v2.14.1

Steps to reproduce

  • Install the @nuxt/vuetify module and vue-cli-plugin-vuetify-preset-rally
  • Add the following to nuxt.config.js
vuetify: {
    customVariables: ["vue-cli-plugin-vuetify-preset-rally/preset/variables.scss"],
    preset: "vue-cli-plugin-vuetify-preset-rally/preset"
},
build: {
    transpile: ["vue-cli-plugin-vuetify-preset-rally"],
    ...
}

What is Expected?

That whatever is defined in the presets variables.scss file to be applied to the components (in other words, for it to prepend that file to all scss files). When running in the normal nuxt environment it works, but not in storybook.

What is actually happening?

None of those styles are applied

@adamskeeled adamskeeled added the type: bug Something isn't working label Aug 17, 2020
@farnabaz
Copy link
Collaborator

farnabaz commented Aug 24, 2020

Wrap your stories inside v-app.

Unfortunately, Vuetify forces to use v-app around the application.

Update: I've created a Vuetify example, take a look :)

@adamskeeled
Copy link
Author

I actually already had a global decorator which added v-app (the example is still a great addition and reference point, thank you!). Unfortunately it still doesn't seem to be applying any of the custom variables defined in a vuetify presets variables.scss 😕

@farnabaz
Copy link
Collaborator

Try adding v-app inside the story itself.
Also, could you provide a reproduction sample? Using v-app was solve the issue in my project.

@adamskeeled
Copy link
Author

Hey @farnabaz, sorry for the late response. With the new 2.2.0 version this seems to working now for me. Regarding adding v-app inside the story, I made a comment here #1 (comment) about that

@farnabaz
Copy link
Collaborator

farnabaz commented Sep 2, 2020

Glad to hear it 👍

I close this issue.
Feel free to reopen it if the issue persists

@farnabaz farnabaz closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants