fix: prefer #app useHead #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 2 2
Lines 115 115
Branches 13 13
=======================================
Hits 95 95
Misses 20 20 馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more |
|
This is quite bizarre and worth investigating further, thanks for your efforts! |
|
I'm not sure this is the right solution. |
dargmuesli
pushed a commit
that referenced
this pull request
Aug 28, 2023
## [0.6.1](v0.6.0...0.6.1) (2023-08-28) ### Bug Fixes * **component:** readd `nextTick` import ([#274](#274)) ([d831058](d831058)) * use `useHead` from `[#imports](https://github.com/nuxt-modules/turnstile/issues/imports)` ([171e351](171e351)), closes [#271](#271)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 馃憢
This PR resolve #250
I've been able to reproduce the issue within the playground as stated in a comment.
So I noticed that
useHead()could notinjectHead()within the turnstile plugin. Switching theuseHead()from#appseems to fix the issue locally for me.Another note is that
useHeadfrom#appanduseHeadfrom#importsare not equal, even the body is different.(maybe is it a nuxt treeshaking or deps optimization issue ?)
Since this issue is quite bizarre, i have no idea on how to reproduce it on e2e tests.
cc @harlan-zw