Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt 3 support #43

Closed
Baroshem opened this issue Mar 24, 2022 · 5 comments · Fixed by #59
Closed

Nuxt 3 support #43

Baroshem opened this issue Mar 24, 2022 · 5 comments · Fixed by #59
Assignees

Comments

@Baroshem
Copy link
Collaborator

Hey,

I will work on making the module work with Nuxt 3 out of the box.

@pi0 pi0 assigned pi0 and Baroshem and unassigned pi0 Mar 24, 2022
@Baroshem
Copy link
Collaborator Author

The work is currently done on the next branch and will be released probably next week after some testing.

@andreemic
Copy link

That's awesome! How is it going? ETA?

@Baroshem
Copy link
Collaborator Author

@andreemic

The PR is ready. Just waiting to be reviewed and merged 🙂

@maximilian-schwarz
Copy link

Any news?

@YangHanlin
Copy link

YangHanlin commented Nov 22, 2022

Is there any update regarding this issue and its related PR #47? According to a comment in the PR, the main branch is already working well with Nuxt 3; but it is unfortunately not true with nuxt@3.0.0-rc.14 or later versions (including the stable release nuxt@3.0.0). The error is likely to be related with nuxt/framework@74b81bb.

Logs of postinstall script with @nuxtjs/web-vitals@0.1.10 (latest release on main branch) and nuxt@3.0.0-rc.13:

home postinstall$ nuxt prepare
│ Nuxi 3.0.0-rc.13
│  WARN  [@nuxtjs/web-vitals] Please define a provider to activate this module
│  ERROR  (node:42744) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
│ (Use `node --trace-warnings ...` to show where the warning was created)
│ √ Types generated in .nuxt
└─ Done in 3.1s

compared with logs of postinstall script with @nuxtjs/web-vitals@0.1.10 (latest release on main branch) and nuxt@3.0.0-rc.14:

home postinstall$ nuxt prepare
│ Nuxi 3.0.0-rc.14
│  ERROR  Cannot destructure property 'nuxt' of 'this' as it is undefined.
│   at webVitalsModule (D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/@nuxtjs+web-vitals@0.1.10/node_modules/@nuxtjs/web-vitals/dist/index.j
│   at installModule (/D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/@nuxt+kit@3.0.0-rc.14_rollup@2.79.1/node_modules/@nuxt/kit/dist/index.m
│   at async initNuxt (/D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/nuxt@3.0.0-rc.14_t7kkosihzizynsd35m2tpz76wa/node_modules/nuxt/dist/ind
│   at async loadNuxt (/D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/nuxt@3.0.0-rc.14_t7kkosihzizynsd35m2tpz76wa/node_modules/nuxt/dist/ind
│   at async loadNuxt (/D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/@nuxt+kit-edge@3.0.0-rc.14-27796957.b60f136_rollup@2.79.1/node_modules
│   at async Object.invoke (/D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/nuxi@3.0.0-rc.14/node_modules/nuxi/dist/chunks/prepare.mjs:30:18)
│   at async _main (/D:/Areas/Workspaces/GitHubRepos/tdcloud/node_modules/.pnpm/nuxi@3.0.0-rc.14/node_modules/nuxi/dist/cli.mjs:50:20)
└─ Failed in 2.2s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants