Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use consola so that this.options.build.quiet is taken into account #184

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

dword-design
Copy link
Contributor

Nuxt has the this.options.build.quiet variable to decide if console output should happen. It sets consola.level depending on this variable.

@nuxt/components should also use consola so that the output is muted correctly. Currently, @nuxt/components still outputs to the console if Nuxt is built via the API.

I added consola as a peer dependency so that it does not install its own version.

It's actually a bit hard to test this because @nuxt/components is directly integrated into Nuxt.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #184 (c059bad) into main (bcb8cd8) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   86.04%   86.04%           
=======================================
  Files           7        7           
  Lines         172      172           
  Branches       45       45           
=======================================
  Hits          148      148           
  Misses         24       24           
Impacted Files Coverage Δ
src/index.ts 75.36% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb8cd8...c059bad. Read the comment docs.

@pi0 pi0 merged commit c6c3f66 into nuxt:main Apr 28, 2021
@pi0
Copy link
Member

pi0 commented Apr 28, 2021

Thanks!

@dword-design dword-design deleted the consola branch April 28, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants