Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove numeric prefix from component names #222

Merged
merged 8 commits into from
Aug 11, 2021
Merged

feat: remove numeric prefix from component names #222

merged 8 commits into from
Aug 11, 2021

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 11, 2021

Context: #218, #218 (comment)

This feature allows adding prefixes to the directory or component names for easier sorting in the filesystem (base/a.vue => 1-base/1.a.vue). Until now such prefix was causing an error, it is a non-breaking change.


Point by @AMoreaux (#218 (comment)):

risk with this is a use case with two folders named: 01.atoms and 02.atoms.
The object keys can't have the same name. We could use a revision number for each component, but I can't evaluate the side effect of this change.

This is not an intended use of structure. In such case, we show a warning about name conflict but users should either do:

  • Use separate branches for versioning
  • Using clear distinct prefix like BaseV1/
  • Using nuxtignore patterns like -Base/

Using numbers is also not valid for both Javascript/ESM identifiers and HTML tags

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #222 (0b0a762) into main (2917fc3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files           7        7           
  Lines         175      175           
  Branches       48       48           
=======================================
  Hits          151      151           
  Misses         24       24           
Impacted Files Coverage Δ
src/scan.ts 98.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2917fc3...0b0a762. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant