Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix argument of onError #67

Merged
merged 1 commit into from
Sep 1, 2019
Merged

fix(types): fix argument of onError #67

merged 1 commit into from
Sep 1, 2019

Conversation

edimitchel
Copy link
Contributor

On Nuxt TypeScript project using http module, we have a type error from tslint

 ERROR  ERROR in /.../node_modules/@nuxt/http/types/index.d.ts(141,18):
141:18 Parameter has a name but no type. Did you mean 'arg0: HTTPError'?
    139 |    * This hook enables you to globally handle request errors.
    140 |    */
  > 141 |   onError(hook: (HTTPError) => void): void
        |                  ^
    142 | }
    143 | 
    144 | declare module '@nuxt/vue-app' {

This fix handle simply this typing issue.

@pi0
Copy link
Member

pi0 commented Sep 1, 2019

Thanks!

@pi0 pi0 merged commit be10314 into nuxt:dev Sep 1, 2019
@edimitchel
Copy link
Contributor Author

@pi0 When is scheduled a release for getting this small fix ?

@edimitchel edimitchel deleted the patch-1 branch September 2, 2019 06:33
@pi0
Copy link
Member

pi0 commented Sep 5, 2019

Sorry for being late. https://github.com/nuxt/http/releases/tag/v0.3.5 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants