Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure static image map is available on first load #236

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Apr 27, 2021

  • Worth also considering whether to use fetch (object syntax, but would require Nuxt 2.15+) vs data (?)

closes #234

Likely also addresses #167 (comment), #215 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021

Codecov Report

Merging #236 (6b82aad) into main (9561daf) will decrease coverage by 0.44%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   62.70%   62.25%   -0.45%     
==========================================
  Files          23       23              
  Lines         555      559       +4     
  Branches      160      162       +2     
==========================================
  Hits          348      348              
- Misses        207      211       +4     
Impacted Files Coverage Δ
src/runtime/image.ts 69.52% <0.00%> (-0.67%) ⬇️
src/runtime/utils/static-map.ts 6.66% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9561daf...6b82aad. Read the comment docs.

@danielroe danielroe requested a review from pi0 April 27, 2021 11:42
src/runtime/image.ts Show resolved Hide resolved
@tanc
Copy link
Contributor

tanc commented Apr 27, 2021

Confirmed that with these applied changes the client now gets the correct mapping returned. Thanks!

@pi0 pi0 merged commit 466d5a8 into main Apr 27, 2021
@pi0 pi0 deleted the fix/static-image-payload branch April 27, 2021 16:53
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$img does not return the correct url on nuxt generated pages
4 participants