Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): add imgix provider #29

Merged
merged 7 commits into from
Oct 14, 2020
Merged

feat(runtime): add imgix provider #29

merged 7 commits into from
Oct 14, 2020

Conversation

daletom
Copy link
Contributor

@daletom daletom commented Oct 9, 2020

I've successfully added imgix as an image provider to nuxt/image. I added an image using imgix to the demo as well (woman in blue hat). I've also mirrored the readme portions and connected the corresponding fit modes in the runtime.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the integration 🙂

@@ -33,6 +33,7 @@ export default {
images: [
{ src: 'cloudinary:/remote/nuxt-org/blog/going-full-static/main.png', alt: 'Cloudinary' },
{ src: 'fastly:/image.jpg', alt: 'fastify' },
{ src: 'imgix:/examples/bluehat.jpg', alt: 'imgix'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix lint error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, sorry about that. Fixed the lint error.

@daletom daletom requested a review from farnabaz October 13, 2020 17:24
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@farnabaz farnabaz changed the title feat: add imgix as an image provider feat(runtime): add imgix provider Oct 14, 2020
@farnabaz farnabaz merged commit 3f4a6a5 into nuxt:master Oct 14, 2020
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants