Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure payload includes up-to-date _img #303

Merged
merged 2 commits into from
Jun 2, 2021
Merged

fix: ensure payload includes up-to-date _img #303

merged 2 commits into from
Jun 2, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 29, 2021

I'm not sure why beforeNuxtRender isn't properly setting the page data but this does fix the issue

closes #297

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #303 (c70ccb6) into main (e71311f) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   58.08%   57.77%   -0.31%     
==========================================
  Files          25       25              
  Lines         563      566       +3     
  Branches      169      170       +1     
==========================================
  Hits          327      327              
- Misses        236      239       +3     
Impacted Files Coverage Δ
src/runtime/image.ts 67.88% <0.00%> (-1.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71311f...c70ccb6. Read the comment docs.

@danielroe danielroe requested a review from pi0 May 29, 2021 14:12
@pi0 pi0 merged commit 03ea6fe into main Jun 2, 2021
@pi0 pi0 deleted the fix/img-payload branch June 2, 2021 13:06
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static target points original path when route by vue-router
3 participants