Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(imagekit): add modifiers and improve docs #336

Merged
merged 18 commits into from
Jun 30, 2021

Conversation

abhinavr4
Copy link
Contributor

@abhinavr4 abhinavr4 commented Jun 24, 2021

Added-

  1. Detailed documentation for ImageKit provider.
  2. Names for ImageKit transformations - provider modifiers.
  3. Playground examples.

Relevant issue - #271

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #336 (343b03a) into main (d9aeae2) will increase coverage by 0.13%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   59.36%   59.50%   +0.13%     
==========================================
  Files          26       26              
  Lines         598      600       +2     
  Branches      149      187      +38     
==========================================
+ Hits          355      357       +2     
  Misses        243      243              
Impacted Files Coverage Δ
src/runtime/providers/imagekit.ts 69.23% <66.66%> (+5.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9aeae2...343b03a. Read the comment docs.

@pi0 pi0 changed the title feat: Adding ImageKit modifiers and its detailed documentation feat(imagekit): add modifiers and improve docs Jun 30, 2021
@pi0 pi0 merged commit d53fda5 into nuxt:main Jun 30, 2021
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants