Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): unsplash #357

Merged
merged 7 commits into from
Jul 8, 2021
Merged

Conversation

shadow81627
Copy link
Contributor

resolves #353

@shadow81627
Copy link
Contributor Author

I didn't realise before I created this provider that there is an alias feature that is used by ipx for unsplash in the playground. Could I get some help with improving the unsplash provider docs to mention ipx unsplash alias support?

test/unit/providers.test.ts Outdated Show resolved Hide resolved
test/unit/providers.test.ts Outdated Show resolved Hide resolved
docs/content/en/4.providers/unsplash.md Outdated Show resolved Hide resolved
test/providers.ts Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Jul 7, 2021

I didn't realise before I created this provider that there is an alias feature that is used by ipx for unsplash in the playground. Could I get some help with improving the unsplash provider docs to mention ipx unsplash alias support?

Sure. Feel free changing alias example to something else :)

Co-authored-by: pooya parsa <pyapar@gmail.com>
test/providers.ts Outdated Show resolved Hide resolved
test/providers.ts Outdated Show resolved Hide resolved
test/providers.ts Outdated Show resolved Hide resolved
test/providers.ts Outdated Show resolved Hide resolved
test/providers.ts Outdated Show resolved Hide resolved
test/providers.ts Outdated Show resolved Hide resolved
playground/providers.ts Outdated Show resolved Hide resolved
@shadow81627 shadow81627 requested a review from pi0 July 7, 2021 01:22
@shadow81627 shadow81627 requested a review from pi0 July 7, 2021 11:11
Co-authored-by: Damien Robinson <damien.robinson@pocketpasta.com>
@pi0 pi0 merged commit ad6c1ae into nuxt:main Jul 8, 2021
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: unsplash support
2 participants