feat: load all images on print #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Nov 5, 2020
| return observer | ||
| } | ||
|
|
||
| function createObserver (intersectionOptions: object) { |
There was a problem hiding this comment.
I think for longer term it would be better to create observer directly in component instead of share runtime logic (createObserver(image))
There was a problem hiding this comment.
If we move observer into component we are creating multiple query match and IntersectionOsberver. I'm not sure but it may reduce the performance
pi0
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
window.matchMediato detect print media query and load all images on the page.close #56