fix: mark runtime/ directory as external

resolves #242
nuxt · Apr 25, 2024 · 7a68e1e · 7a68e1e
1 parent 3a54a33
commit 7a68e1e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/example/src/module.ts b/example/src/module.ts
@@ -1,8 +1,12 @@
 import { defineNuxtModule, addPlugin, createResolver } from '@nuxt/kit'
 
+// https://github.com/nuxt/module-builder/issues/242
+import type { SharedTypeFromRuntime } from './runtime/plugins/plugin'
+
 // Module options TypeScript interface definition
 export interface ModuleOptions {
   apiKey: string
+  shared?: SharedTypeFromRuntime
 }
 
 export interface ModuleHooks {
@@ -33,6 +37,9 @@ export default defineNuxtModule<ModuleOptions>({
   setup(_options, _nuxt) {
     const resolver = createResolver(import.meta.url)
 
+    // @ts-expect-error type should be resolved
+    _options.shared = 'not-shared-type'
+
     // Do not add the extension since the `.ts` will be transpiled to `.mjs` after `npm run prepack`
     addPlugin(resolver.resolve('./runtime/plugins/plugin'))
   },

diff --git a/example/src/runtime/plugins/plugin.ts b/example/src/runtime/plugins/plugin.ts
@@ -1,5 +1,7 @@
 import { defineNuxtPlugin } from '#app'
 
+export type SharedTypeFromRuntime = 'shared-type'
+
 export default defineNuxtPlugin(() => {
   console.log('Plugin injected by my-module!')
   return {

diff --git a/src/commands/build.ts b/src/commands/build.ts
@@ -58,6 +58,7 @@ export default defineCommand({
         cjsBridge: true,
       },
       externals: [
+        /src\/runtime/,
         '@nuxt/schema',
         '@nuxt/schema-nightly',
         '@nuxt/schema-edge',