Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hotfix): preload modern resource in spa modern mode #5043

Merged
merged 1 commit into from Feb 15, 2019
Merged

fix(hotfix): preload modern resource in spa modern mode #5043

merged 1 commit into from Feb 15, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Feb 15, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested a review from pi0 February 15, 2019 12:03
@clarkdo clarkdo mentioned this pull request Feb 15, 2019
Closed
@clarkdo
Copy link
Member Author

clarkdo commented Feb 15, 2019 •
edited

@pi0 The audit error comes from v3.13.0 which has been fixed in v3.13.0

@clarkdo clarkdo merged commit 3516580 into nuxt:2.x Feb 15, 2019
@pi0 pi0 mentioned this pull request Feb 25, 2019
Closed
@pi0 pi0 mentioned this pull request Mar 14, 2019
Merged
@clarkdo clarkdo deleted the spa-preload branch April 2, 2019 13:14
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clarkdo @pi0 @danielroe