New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix chrome detection in macOS Catalina #6638
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #6638 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 78 78
Lines 2713 2713
Branches 702 702
=======================================
Hits 2600 2600
Misses 98 98
Partials 15 15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #6638 +/- ##
===========================================
- Coverage 95.83% 64.65% -31.19%
===========================================
Files 78 78
Lines 2713 2713
Branches 702 702
===========================================
- Hits 2600 1754 -846
- Misses 98 764 +666
- Partials 15 195 +180
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #6638 +/- ##
===========================================
- Coverage 95.83% 64.65% -31.19%
===========================================
Files 78 78
Lines 2713 2713
Branches 702 702
===========================================
- Hits 2600 1754 -846
- Misses 98 764 +666
- Partials 15 195 +180
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #6638 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 78 78
Lines 2713 2713
Branches 702 702
=======================================
Hits 2600 2600
Misses 98 98
Partials 15 15
Continue to review full report at Codecov.
|
Related to nuxt-contrib/tib#29
In macOS Catalina, the matched app contains hex like
/Applications/Google Chrome.app (0xc54)
, this pr is using a more accurate way to resolve app path.