Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix chrome detection in macOS Catalina #6638

Merged
merged 6 commits into from Nov 9, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Oct 30, 2019

Related to nuxt-contrib/tib#29

In macOS Catalina, the matched app contains hex like /Applications/Google Chrome.app (0xc54), this pr is using a more accurate way to resolve app path.

@clarkdo clarkdo requested a review from a team October 30, 2019 18:51
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #6638 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6638   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          78       78           
  Lines        2713     2713           
  Branches      702      702           
=======================================
  Hits         2600     2600           
  Misses         98       98           
  Partials       15       15
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.65% <ø> (ø) ⬆️
#unit 92.33% <ø> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb38fe...11c5a54. Read the comment docs.

@clarkdo clarkdo changed the title test: fix chrome detection in macOS Catalina [WIP] test: fix chrome detection in macOS Catalina Oct 30, 2019
@clarkdo clarkdo added the WIP label Oct 30, 2019
@clarkdo clarkdo changed the title [WIP] test: fix chrome detection in macOS Catalina test: fix chrome detection in macOS Catalina Oct 31, 2019
@clarkdo clarkdo removed the WIP label Oct 31, 2019
@codecov-io
Copy link

Codecov Report

Merging #6638 into dev will decrease coverage by 31.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev    #6638       +/-   ##
===========================================
- Coverage   95.83%   64.65%   -31.19%     
===========================================
  Files          78       78               
  Lines        2713     2713               
  Branches      702      702               
===========================================
- Hits         2600     1754      -846     
- Misses         98      764      +666     
- Partials       15      195      +180
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.65% <ø> (ø) ⬆️
#unit ?
Impacted Files Coverage Δ
packages/cli/src/options/server.js 0% <0%> (-100%) ⬇️
packages/cli/src/utils/banner.js 0% <0%> (-100%) ⬇️
packages/cli/src/run.js 0% <0%> (-100%) ⬇️
packages/cli/src/commands/start.js 0% <0%> (-100%) ⬇️
packages/cli/src/list.js 0% <0%> (-100%) ⬇️
packages/cli/src/utils/memory.js 0% <0%> (-100%) ⬇️
packages/server/src/listener.js 1.69% <0%> (-98.31%) ⬇️
packages/server/src/middleware/error.js 4.16% <0%> (-95.84%) ⬇️
packages/server/src/middleware/timing.js 4.54% <0%> (-95.46%) ⬇️
packages/server/src/middleware/nuxt.js 5.26% <0%> (-92.11%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb38fe...11c5a54. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #6638 into dev will decrease coverage by 31.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev    #6638       +/-   ##
===========================================
- Coverage   95.83%   64.65%   -31.19%     
===========================================
  Files          78       78               
  Lines        2713     2713               
  Branches      702      702               
===========================================
- Hits         2600     1754      -846     
- Misses         98      764      +666     
- Partials       15      195      +180
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.65% <ø> (ø) ⬆️
#unit ?
Impacted Files Coverage Δ
packages/cli/src/options/server.js 0% <0%> (-100%) ⬇️
packages/cli/src/utils/banner.js 0% <0%> (-100%) ⬇️
packages/cli/src/run.js 0% <0%> (-100%) ⬇️
packages/cli/src/commands/start.js 0% <0%> (-100%) ⬇️
packages/cli/src/list.js 0% <0%> (-100%) ⬇️
packages/cli/src/utils/memory.js 0% <0%> (-100%) ⬇️
packages/server/src/listener.js 1.69% <0%> (-98.31%) ⬇️
packages/server/src/middleware/error.js 4.16% <0%> (-95.84%) ⬇️
packages/server/src/middleware/timing.js 4.54% <0%> (-95.46%) ⬇️
packages/server/src/middleware/nuxt.js 5.26% <0%> (-92.11%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb38fe...11c5a54. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #6638 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6638   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          78       78           
  Lines        2713     2713           
  Branches      702      702           
=======================================
  Hits         2600     2600           
  Misses         98       98           
  Partials       15       15
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.65% <ø> (ø) ⬆️
#unit 92.33% <ø> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb38fe...11c5a54. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants