fix(vue-app): handle server-side routing errors

[matthieusieben]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #7798

https://github.com/nuxt/nuxt.js/blob/4caffb04ab9309fb334f68739c61b73f8c325a05/packages/vue-app/template/index.js#L248-L268

This introduces a fix for 2 use cases:

• The user uses next(err) in a router guard. This will generate a 500 error.
• The user uses next(false) in a router guard. This will:
  • Either render any error provided through context.error()
  • Or generate a 404 (by default)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-commenter]

Codecov Report

Merging #7801 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #7801   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          90       90           
  Lines        3838     3838           
  Branches     1038     1038           
=======================================
  Hits         2644     2644           
  Misses        970      970           
  Partials      224      224           

Flag	Coverage Δ
#unittests	68.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab30bbc...422d3ac. Read the comment docs.

[matthieusieben]

These changes will imply that users should never do next(err) (or they will get a 500) but do error(err); next(false) instead.

Note that in the browser, nothing will happen if a user does next(err) except from displaying an error in the console.

[pi0]

Thanks for PR @matthieusieben ❤️