Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use node 18 for ci jobs #23701

Merged
merged 5 commits into from Oct 16, 2023
Merged

ci: use node 18 for ci jobs #23701

merged 5 commits into from Oct 16, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This updates our CI to node 18 for the 2.x branch.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests βœ…

Comparison is base (46160bf) 66.20% compared to head (4407f58) 66.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x   #23701   +/-   ##
=======================================
  Coverage   66.20%   66.20%           
=======================================
  Files          93       93           
  Lines        4119     4119           
  Branches     1169     1169           
=======================================
  Hits         2727     2727           
  Misses       1126     1126           
  Partials      266      266           
Flag Coverage Ξ”
unittests 66.20% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit c1bbc5f into 2.x Oct 16, 2023
13 checks passed
@danielroe danielroe deleted the ci/node-18 branch October 16, 2023 21:23
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants