Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove md4 patch now that webpack has it in core #23703

Merged
merged 1 commit into from Oct 16, 2023
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

webpack/webpack#17628
#19108

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Now that webpack has support for md4 in latest node versions, this PR removes our monkey-patch.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Oct 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests βœ…

Comparison is base (b1e08a9) 66.13% compared to head (bbe6356) 66.20%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x   #23703      +/-   ##
==========================================
+ Coverage   66.13%   66.20%   +0.07%     
==========================================
  Files          93       93              
  Lines        4125     4119       -6     
  Branches     1171     1169       -2     
==========================================
- Hits         2728     2727       -1     
+ Misses       1130     1126       -4     
+ Partials      267      266       -1     
Flag Coverage Ξ”
unittests 66.20% <ΓΈ> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
packages/config/src/options.js 94.77% <ΓΈ> (+1.83%) ⬆️

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix: remove monkey patch now that webpack has it in core fix: remove md4 patch now that webpack has it in core Oct 16, 2023
@danielroe danielroe merged commit fc65b36 into 2.x Oct 16, 2023
13 checks passed
@danielroe danielroe deleted the fix/monkey branch October 16, 2023 14:21
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
@GMartigny
Copy link

Hi,

How does one use this ? As far as I see, webpack is still hardocded with md4 that still raise an error in Node 17+.

@danielroe
Copy link
Member Author

The latest webpack is no longer hardcoded with md4, but if you need to you can add the code this PR removed into your own nuxt.config within your buildModules array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants