Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to hookable package #24426

Merged
merged 3 commits into from Nov 24, 2023
Merged

Conversation

AndreyYolkin
Copy link
Contributor

πŸ”— Linked issue

Resolves: #24419

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR moves Nuxt 2 to the hable package successor, hookable, which allows us to unregister hooks and create developer experience more similar to Nuxt 3 / Bridge

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Nov 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (9d6584b) 66.20% compared to head (6d573e2) 66.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x   #24426      +/-   ##
==========================================
+ Coverage   66.20%   66.22%   +0.01%     
==========================================
  Files          93       93              
  Lines        4119     4121       +2     
  Branches     1169     1169              
==========================================
+ Hits         2727     2729       +2     
  Misses       1126     1126              
  Partials      266      266              
Flag Coverage Ξ”
unittests 66.22% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe requested a review from pi0 November 23, 2023 20:49
@danielroe danielroe added the 2.x label Nov 23, 2023
@danielroe danielroe merged commit 21776e5 into nuxt:2.x Nov 24, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants