Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require postcss module via resolver #4737

Merged
merged 4 commits into from Jan 11, 2019
Merged

Conversation

manniL
Copy link
Member

@manniL manniL commented Jan 11, 2019

Can be useful when trying to run a nuxt app in another folder, eg. via

yarn nuxt ../my-app or yarn nuxt -c ../my-app/nuxt.config.js

Otherwise, PostCSS plugins will be taken from the current working dir which probably doesn't have the plugins (in the above case it's the root dir of the nuxtjs repo)

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

  • New feature (a non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

  • My change requires a change to the documentation.

  • I have updated the documentation accordingly. (PR: #)

  • I have added tests to cover my changes (if not applicable, please state why)

  • All new and existing tests are passing.

packages/webpack/src/utils/postcss.js Outdated Show resolved Hide resolved
packages/webpack/src/utils/postcss.js Outdated Show resolved Hide resolved
pi0
pi0 previously approved these changes Jan 11, 2019
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #4737 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4737      +/-   ##
==========================================
+ Coverage   90.14%   90.18%   +0.04%     
==========================================
  Files          67       67              
  Lines        2282     2282              
  Branches      565      565              
==========================================
+ Hits         2057     2058       +1     
+ Misses        202      201       -1     
  Partials       23       23
Impacted Files Coverage Δ
packages/webpack/src/utils/postcss.js 94.11% <100%> (ø) ⬆️
packages/core/src/resolver.js 85.48% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d651a...bcdd779. Read the comment docs.

@clarkdo clarkdo merged commit 4b9e8e7 into dev Jan 11, 2019
@manniL manniL deleted the fix/requirePostcssModule branch January 11, 2019 15:12
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants