Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): skip esm for node_modules and non .js files #5220

Merged
merged 8 commits into from Mar 13, 2019
Merged

perf(core): skip esm for node_modules and non .js files #5220

merged 8 commits into from Mar 13, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Mar 13, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Skip using esm for files inside node_modules and only use for .js/.mjs files (resolved first!). useESM set to true for modules to prevent breaking changes on 2.x.

Also fixes #5203.

Currently startup of nuxt dev requires these:

/node_modules/node-fetch/package.json
/node_modules/unfetch/package.json
/node_modules/vue/package.json
/node_modules/vue-meta/package.json
/node_modules/vue-no-ssr/package.json
/node_modules/vue-router/package.json
/node_modules/vue-template-compiler/package.json
/node_modules/vuex/package.json
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js
/node_modules/postcss-import/index.js
/node_modules/postcss-url/src/index.js
/node_modules/postcss-preset-env/index.js
/node_modules/cssnano/dist/index.js

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #5220 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5220      +/-   ##
==========================================
+ Coverage   96.28%   96.32%   +0.04%     
==========================================
  Files          73       73              
  Lines        2476     2478       +2     
  Branches      628      630       +2     
==========================================
+ Hits         2384     2387       +3     
+ Misses         77       76       -1     
  Partials       15       15
Impacted Files Coverage Δ
packages/core/src/module.js 98.33% <100%> (+0.05%) ⬆️
packages/core/src/resolver.js 98.43% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 94.89% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37006f6...a3a6fc3. Read the comment docs.

@pi0 pi0 merged commit aabb1f6 into dev Mar 13, 2019
@pi0 pi0 deleted the perf/esm branch March 13, 2019 10:24
@pi0 pi0 mentioned this pull request Mar 14, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants