-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): fix production font preloading #5436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #5436 +/- ##
==========================================
+ Coverage 95.68% 95.69% +<.01%
==========================================
Files 78 78
Lines 2595 2600 +5
Branches 661 663 +2
==========================================
+ Hits 2483 2488 +5
Misses 93 93
Partials 19 19
Continue to review full report at Codecov.
|
pi0
reviewed
Apr 1, 2019
aldarund
approved these changes
Apr 1, 2019
galvez
approved these changes
Apr 2, 2019
atinux
approved these changes
Apr 5, 2019
manniL
approved these changes
Apr 5, 2019
pi0
approved these changes
Apr 5, 2019
Since the pr in Vue repo is no luck for 3 weeks, so let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
In production,
App.js
js is concatenated by webpack, so there is noApp.js
module infoin
client.manifest.json
.Way to preload fonts if anyone is interested in verifying the issue:
Checklist: