Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): serialize inline functions (#5051) #5580

Merged
merged 14 commits into from Apr 22, 2019
Merged

fix(utils): serialize inline functions (#5051) #5580

merged 14 commits into from Apr 22, 2019

Conversation

galvez
Copy link

@galvez galvez commented Apr 22, 2019

Resolves #5051

@galvez galvez closed this Apr 22, 2019
@galvez galvez reopened this Apr 22, 2019
@galvez galvez requested a review from a team April 22, 2019 15:01
@galvez galvez self-assigned this Apr 22, 2019
pimlie
pimlie reviewed Apr 22, 2019
View reviewed changes
packages/utils/src/serialize.js Outdated Show resolved Hide resolved
packages/utils/src/serialize.js Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 22, 2019 •
edited

Codecov Report

Merging #5580 into dev will decrease coverage by <.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5580      +/-   ##
==========================================
- Coverage   95.64%   95.63%   -0.01%     
==========================================
  Files          81       81              
  Lines        2617     2636      +19     
  Branches      665      671       +6     
==========================================
+ Hits         2503     2521      +18     
- Misses         95       96       +1     
  Partials       19       19
Impacted Files Coverage Δ
packages/utils/src/serialize.js 92.85% <94.73%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cc8de...938f005. Read the comment docs.

pi0
pi0 previously approved these changes Apr 22, 2019
View reviewed changes
@pi0 pi0 changed the title fix: serialize inline function fix(utils): serialize inline function (#5051) Apr 22, 2019
@pi0 pi0 changed the title fix(utils): serialize inline function (#5051) fix(utils): serialize inline functions (#5051) Apr 22, 2019
@pi0 pi0 merged commit 88a78ff into dev Apr 22, 2019
@pi0 pi0 deleted the fix/serialize-inline-function branch April 22, 2019 18:47
pi0 pushed a commit that referenced this pull request Apr 22, 2019
@galvez
fix(utils): serialize inline functions (#5051) (#5580)
3436136
This was referenced Apr 22, 2019
Merged
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimlie pimlie pimlie approved these changes

@pi0 pi0 pi0 left review comments

@clarkdo clarkdo Awaiting requested review from clarkdo

@aldarund aldarund Awaiting requested review from aldarund

@manniL manniL Awaiting requested review from manniL

Assignees

@galvez galvez

Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

titleTemplate with arrow function expression produces an error
5 participants
@galvez @codecov-io @pimlie @pi0 @danielroe