Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): fix router.extendRoutes method type #5700

Merged
merged 1 commit into from May 11, 2019
Merged

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented May 11, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes https://github.com/nuxt/nuxt.js/issues/5693

Credits

Co-authored-by: @renestalder

Co-authored-by: René Stalder <renestalder@protonmail.com>
@kevinmarrec kevinmarrec requested a review from a team May 11, 2019 13:20
@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #5700 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #5700   +/-   ##
=====================================
  Coverage   95.6%   95.6%           
=====================================
  Files         82      82           
  Lines       2664    2664           
  Branches     683     683           
=====================================
  Hits        2547    2547           
  Misses        98      98           
  Partials      19      19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6775024...42a470d. Read the comment docs.

@kevinmarrec kevinmarrec changed the title fix(ts): fix extendRoutes method type fix(ts): fix router.extendRoutes method type May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants