-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-app): emit triggerScroll to support hash navigation #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #6012 +/- ##
=======================================
Coverage 95.72% 95.72%
=======================================
Files 82 82
Lines 2689 2689
Branches 690 690
=======================================
Hits 2574 2574
Misses 97 97
Partials 18 18
Continue to review full report at Codecov.
|
pi0
approved these changes
Jul 1, 2019
atinux
approved these changes
Jul 2, 2019
Thanks @pimlie |
manniL
approved these changes
Jul 3, 2019
Merged
atinux
pushed a commit
that referenced
this pull request
Jul 30, 2019
pi0
pushed a commit
that referenced
this pull request
Aug 20, 2019
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Nuxt's scrollBehaviour relies on the triggerScroll event which is only emitted when a new component is loaded. This means the event will never be emitted when you navigate within an active component using hashes.
Checklist: