Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that user should not use separate nitro.config.ts (and other configs like webpack/vitest/...) #15085

Closed
4 tasks done
manniL opened this issue Oct 3, 2022 · 4 comments

Comments

@manniL
Copy link
Member

manniL commented Oct 3, 2022

Describe the feature

When using Nuxt, the nitro config should live inside the nuxt.config.{js,ts} instead of a separate nitro.config.{js,ts}. Same for a custom webpack or vite config. Ideally this should be documented.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

@pi0
Copy link
Member

pi0 commented Nov 7, 2022

As discussed in nuxt/framework#8683 we can improve Nitro docs to guide Nuxt users.

It wouldn't hurt to also add a Nitro Configuration section in https://v3.nuxtjs.org/guide/directory-structure/server IMO to clarify this.

@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe transferred this issue from nuxt/framework Jan 19, 2023
@manniL manniL changed the title Warn user when using a separate nitro.config.ts Document that user should not use separate nitro.config.ts (and other configs like webpack/vitest/...) Dec 25, 2023
@manniL manniL removed the discussion label Dec 25, 2023
@danielroe
Copy link
Member

I think we might be able to close this as completed in #22521. What do you think?

We can also add to docs...

@pi0
Copy link
Member

pi0 commented Jan 3, 2024

I think the warning is enough to close this. Nice idea for docs it can be an appendix in here to help users onboard in next steps if they see any (external) docs referring to nitro.config how to translate.

@manniL
Copy link
Member Author

manniL commented Jan 3, 2024

Totally fine - that's what I was suggesting back then too 😂

Happy to see it landed 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants