Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): ignore empty string in app.{rootId|rootTag} #22543

Merged
merged 4 commits into from Aug 9, 2023

Conversation

DamianGlowala
Copy link
Member

πŸ”— Linked issue

Resolves #22525

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR ignores passing empty string for app.rootId and app.rootTag.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@stackblitz
Copy link

stackblitz bot commented Aug 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Lehoczky
Copy link
Contributor

Lehoczky commented Aug 8, 2023

Regarding the discussion in #22525: shall we update the code to validate using a regex, like one suggested in this stackoverflow thread?

@danielroe
Copy link
Member

I'd be happy with that. πŸ‘

@DamianGlowala
Copy link
Member Author

DamianGlowala commented Aug 8, 2023

A separate PR to address the id validation is very much welcome! I wanted to keep these separate, as this PR also ignores an empty string for app.rootTag.

(Well, if Daniel says so, we can update this one as well)

BTW we could go even further and validate the HTML tag (if this brings any value).

@danielroe
Copy link
Member

I think simple validation could be good and maybe even normalisation (e.g. trimming whitespace?), but nothing too complex. Objective is to prevent obvious errors rather than provide a fully safe validation.

@danielroe danielroe changed the title fix(schema): ignore passing empty string for app.rootId and app.rootTag fix(schema): ignore empty string in app.{rootId|rootTag} Aug 9, 2023
@danielroe danielroe merged commit cdcfb1b into main Aug 9, 2023
25 checks passed
@danielroe danielroe deleted the feat/ignore-empty-root-id-and-tag branch August 9, 2023 07:29
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.rootId set to an empty string isn't ignored
3 participants