Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): allow load default spa loading indicator #23047

Closed
davidglezz opened this issue Sep 6, 2023 · 1 comment · Fixed by #23048
Closed

fix(nuxt): allow load default spa loading indicator #23047

davidglezz opened this issue Sep 6, 2023 · 1 comment · Fixed by #23048

Comments

@davidglezz
Copy link
Contributor

davidglezz commented Sep 6, 2023

Environment

  • Operating System: Darwin
  • Node Version: v20.1.0
  • Nuxt Version: 3.7.0
  • CLI Version: 3.7.3
  • Nitro Version: 2.6.2
  • Package Manager: npm@9.6.4
  • Builder: -
  • User Config: ssr, build, modules, app, css, vite, runtimeConfig
  • Runtime Modules: @vueuse/nuxt@10.4.1
  • Build Modules: -

Reproduction

add ~/app/spa-loading-template.html

https://stackblitz.com/edit/github-6nhkcv

Describe the bug

Loading spaLoadingTemplate by default from ~/app/spa-loading-template.html no longer works as documented.

Implemented in #21640

  • Default value: null, then ~/app/spa-loading-template.html was loaded.

Changed default value to false in #22798

  • false if undefined or null, then ~/app/spa-loading-template.html is never loaded.

Additional context

Since last version, spaLoadingTemplate: true only loads nuxt animation and does not load ~/app/spa-loading-template.html if exist.

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants