Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vite-plugin-checker with something else #27759

Closed
3 of 4 tasks
daniluk4000 opened this issue Jun 21, 2024 · 8 comments
Closed
3 of 4 tasks

Replace vite-plugin-checker with something else #27759

daniluk4000 opened this issue Jun 21, 2024 · 8 comments

Comments

@daniluk4000
Copy link
Contributor

daniluk4000 commented Jun 21, 2024

Describe the feature

Yo. Um...

Due to fi3ework/vite-plugin-checker#306 and vuejs/language-tools#4484, I suggest to replace vite-plugin-checker with some existing alternative if it exists, or develop something on Nuxt side.

Reasons:

  1. vue-tsc doesn't really want to update old versions, and even if they would, it won't last forever
  2. plugin checker did not receive update for months
  3. We are now blocked to upgrade to TS 5.5

I know this sounds too hard, but decided to drop it here for consideration. Thanks!

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

@nuxtbot nuxtbot changed the title Replace vite-plugin-checker Error: Missing argument. Please specify the plugin you want to replace with vite-plugin-checker. Jun 21, 2024
@daniluk4000
Copy link
Contributor Author

daniluk4000 commented Jun 21, 2024

What the heck?

Github or someone else deleted my description so I had to reupdate it

@daniluk4000 daniluk4000 changed the title Error: Missing argument. Please specify the plugin you want to replace with vite-plugin-checker. Replace vite-plugin-checker with something else Jun 21, 2024
@so1ve
Copy link

so1ve commented Jun 21, 2024

Made a pr, could you please check if it works? fi3ework/vite-plugin-checker#327
However that's true the repo seemed to be dead, I'd suggest merging my pr into something else

@daniluk4000
Copy link
Contributor Author

Made a pr, could you please check if it works? fi3ework/vite-plugin-checker#327 However that's true the repo seemed to be dead, I'd suggest merging my pr into something else

I'll check if it works. If it does, I suggest we make a fork and upload new package.

Would also be nice if you could fix browser overlay, but it will do for console at least. TS 5.5 is great and I would really love to update.

@so1ve
Copy link

so1ve commented Jun 22, 2024

Browser overlay works, however due to a typescript change(microsoft/TypeScript#58960) global components no longer have correct typings

@daniluk4000
Copy link
Contributor Author

Browser overlay works, however due to a typescript change(microsoft/TypeScript#58960) global components no longer have correct typings

What's about typings btw? Should this be fixed on checker or vue-tsc side?

@manniL
Copy link
Member

manniL commented Jun 27, 2024

According to fi3ework/vite-plugin-checker#327, it will be compatible with vue-tsc 2 in a bit. Only windows tests are failing.

@daniluk4000
Copy link
Contributor Author

According to fi3ework/vite-plugin-checker#327, it will be compatible with vue-tsc 2 in a bit. Only windows tests are failing.

I'll try to look at Window tests, or we'll have to wait a bit. Looks good tho

@manniL
Copy link
Member

manniL commented Jun 27, 2024

On that note, I think vite-plugin-checker should be fine. If there are other concerns, feel free to ping and we can revisit 👍🏻

@manniL manniL closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants