feat(webpack): options.build.loaders.vueStyle #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4837 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 73 73
Lines 2360 2360
Branches 582 582
=======================================
Hits 2152 2152
Misses 190 190
Partials 18 18
Continue to review full report at Codecov.
|
clarkdo
reviewed
Jan 23, 2019
| @@ -11,6 +11,7 @@ export default class StyleLoader { | |||
| this.perfLoader = perfLoader | |||
| this.rootDir = options.rootDir | |||
| this.loaders = { | |||
| ...options.build.loaders, | |||
There was a problem hiding this comment.
This will lead to all loaders which are not related to style like vue-loader, file-loader, ts-loader... are wrapped on style-loader.
There was a problem hiding this comment.
I suggest only add what's needed like loaders.vueStyle in it.
There was a problem hiding this comment.
Sounds much more efficient and safe 👍
I just pushed the change!
@clarkdo
clarkdo
changed the title
pi0
approved these changes
Jan 23, 2019
pi0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When I tried to apply options for vue-style-loader via build.loaders.vueStyle API on nuxt.config.js, it didn't go through correctly.
Checklist: