Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ts-loader to v6 #5667

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2019

This PR contains the following updates:

Package Type Update Change References
ts-loader dependencies major ^5.4.5 -> ^6.0.0 source
ts-loader devDependencies major ^5.4.5 -> ^6.0.0 source

Release Notes

TypeStrong/ts-loader

v6.0.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #5667 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #5667   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          81       81           
  Lines        2645     2645           
  Branches      673      673           
=======================================
  Hits         2528     2528           
  Misses         98       98           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be18b31...a0ef529. Read the comment docs.

@renovate renovate bot force-pushed the renovate/ts-loader-6.x branch from 4e862a6 to 573fb4b Compare May 7, 2019 10:56
@clarkdo
Copy link
Member

clarkdo commented May 7, 2019

@pi0 ts-loader v6 dropped support for node < 8.6 which is inconsistent with our node >= 8

@clarkdo clarkdo added the pending label May 7, 2019
@pi0
Copy link
Member

pi0 commented May 7, 2019

/cc @kevinmarrec

For upcoming nuxt-ts we can change this minimum to 8.6 (as it is new, it is not a real breaking change), or as another option don't upgrade until node8 is not LTS which does not seems a good idea.

@kevinmarrec
Copy link
Contributor

kevinmarrec commented May 7, 2019

@clarkdo @pi0
One of the 2 ts-loader dependencies is a devDependency, so we don't mind.
The other one is shipped with @nuxt/typescript, so wen can force TS users to use node >=8.6

i.e. put this in packages/typescript/package.json :

"engines": {
    "node": ">=8.6.0"
  }

And then, with upcoming nuxt-ts, move or copy this engines statement in nuxt-tsdistribution package.json.

In any cases we just need to tell users that if they want TypeScript with last Nuxt version, they need to run on Node >= 8.6

EDIT : Worth noticing this upgrade won't affect non-TS users, as the node version restriction would be only around @nuxt/typescript package through ts-loader.

@renovate renovate bot force-pushed the renovate/ts-loader-6.x branch 4 times, most recently from 2c8c82e to 1fb2887 Compare May 9, 2019 07:06
@renovate renovate bot changed the title chore(deps): update dependency ts-loader to v6 Update dependency ts-loader to v6 May 9, 2019
@renovate renovate bot force-pushed the renovate/ts-loader-6.x branch 2 times, most recently from 3dee0f7 to 9834e21 Compare May 9, 2019 08:21
@pi0 pi0 mentioned this pull request May 9, 2019
@renovate renovate bot changed the title Update dependency ts-loader to v6 chore(deps): update dependency ts-loader to v6 May 9, 2019
@renovate renovate bot force-pushed the renovate/ts-loader-6.x branch from 9834e21 to ddeb4bf Compare May 9, 2019 12:45
@renovate renovate bot force-pushed the renovate/ts-loader-6.x branch from ddeb4bf to a0ef529 Compare May 10, 2019 09:34
@clarkdo clarkdo closed this May 10, 2019
@clarkdo clarkdo mentioned this pull request May 10, 2019
7 tasks
@renovate
Copy link
Contributor Author

renovate bot commented May 10, 2019

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 6.x releases. However, if you upgrade to 6.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/ts-loader-6.x branch May 10, 2019 10:17
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants