Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content security policy header will lose When status code is 304 #8353

Closed
Zuckjet opened this issue Nov 16, 2020 · 3 comments · Fixed by #8352
Closed

content security policy header will lose When status code is 304 #8353

Zuckjet opened this issue Nov 16, 2020 · 3 comments · Fixed by #8352

Comments

@Zuckjet
Copy link

Zuckjet commented Nov 16, 2020

Versions

  • nuxt: v2.14.7
  • node: v12.16.3

Reproduction

Additional Details

Steps to reproduce

What is Expected?

What is actually happening?

I have a website built with nuxt.js, when I first visit, it has the correct csp header which I set in nuxt.config.js. When I visit this website again, it will lose csp header. And I found that when status code is 304, csp header will lose.

@Zuckjet
Copy link
Author

Zuckjet commented Nov 23, 2020

@pi0 @danielroe Would you please have a look on this issue ? Do you think it is a bug when http status code is 304, the CSP header will lose, if not, is there a configuration can make CSP header work as expected, if it is bug, do you have a plan to publish a patch ? Since this can cause security problem because of the miss of CSP header. Thanks

@pi0 pi0 closed this as completed in #8352 Nov 25, 2020
@pi0 pi0 mentioned this issue Dec 1, 2020
@pi0
Copy link
Member

pi0 commented Dec 1, 2020

This should be fixed in v2.14.8. Please reopen if not.

@Zuckjet
Copy link
Author

Zuckjet commented Dec 3, 2020

This should be fixed in v2.14.8. Please reopen if not.

Thanks. I have confirmed it was solved from v2.14.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants