Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): display progress bar when loading #1362

Merged
merged 2 commits into from
Feb 15, 2024
Merged

feat(Table): display progress bar when loading #1362

merged 2 commits into from
Feb 15, 2024

Conversation

benjamincanac
Copy link
Member

πŸ”— Linked issue

Resolves #1028

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

A Progress will now be displayed when the loading prop is true.

Also, the loadingState will now only be displayed when no rows are provided to prevent flicker.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac merged commit 3fe3521 into dev Feb 15, 2024
2 checks passed
@benjamincanac benjamincanac deleted the feat/1028 branch February 15, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change table loading to simple border animation to avoid UI flicker
1 participant