Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Popover/Dropdown): use @touchstart.passive instead of @touchstart.prevent #1520

Merged
merged 2 commits into from
Mar 17, 2024
Merged

fix(Popover/Dropdown): use @touchstart.passive instead of @touchstart.prevent #1520

merged 2 commits into from
Mar 17, 2024

Conversation

danielohling
Copy link
Contributor

🔗 Linked issue

Resolves #1512

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Change from prevent to passive ontouchstart event.
To fix the bug: [Violation] Added non-passive event listener to a scroll-blocking event. Consider marking event handler as 'passive' to make the page more responsive. See

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielohling
Update Dropdown.vue
864cbf5 
To fix the bug: [Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>
@danielohling
Update Popover.vue
ae5d1c4 
To fix the bug: [Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>
@danielohling danielohling changed the title fix: Prevent [Violation] Added non-passive event listener to a scroll-blocking <some> event fix(UPopover & UDropdown): Prevent [Violation] Added non-passive event listener to a scroll-blocking <some> event Mar 15, 2024
@benjamincanac benjamincanac changed the title fix(UPopover & UDropdown): Prevent [Violation] Added non-passive event listener to a scroll-blocking <some> event fix(Popover/Dropdown): use @touchstart.passive instead of @touchstart.prevent Mar 15, 2024
@benjamincanac benjamincanac merged commit a563d8f into nuxt:dev Mar 17, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

@vahid-bagheri vahid-bagheri mentioned this pull request Apr 3, 2024
Merged
8 tasks
@plushdohn plushdohn mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPopover Added non-passive event listener to a scroll-blocking 'touchstart' event
2 participants
@danielohling @benjamincanac