Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ButtonGroup): nested group elements #1530

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

connerblanton
Copy link
Contributor

@connerblanton connerblanton commented Mar 17, 2024

πŸ”— Linked issue

Resolves #1425

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Updating the useButtonGroup composable to take into account if a parent has already consumed the ButtonGroupContext. If so, then the current child should not also consume that same context.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac merged commit 7658211 into nuxt:dev Mar 17, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @connerblanton! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UBadge not functioning properly within UButtonGroup (Works within UButton)
2 participants