Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms)!: normalize input emits #1560

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(forms)!: normalize input emits #1560

merged 1 commit into from
Mar 25, 2024

Conversation

romhml
Copy link
Collaborator

@romhml romhml commented Mar 25, 2024

πŸ”— Linked issue

Resolves #1113

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Normalize input emits, especially for the change event. This PR includes a small breaking change on the URange, USelect and UCheckbox components: the change event's payload is now the input's value instead of the HTML event to match other inputs.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac changed the title fix: normalize input emits fix!: normalize input emits Mar 25, 2024
@benjamincanac benjamincanac changed the title fix!: normalize input emits fix(forms)!: normalize input emits Mar 25, 2024
@benjamincanac benjamincanac merged commit 92e7362 into dev Mar 25, 2024
2 checks passed
@benjamincanac benjamincanac deleted the fix/input-events branch March 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UToggle give wrong status onClick()
2 participants