Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notification): update timer when timeout prop changes #1673

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

noook
Copy link
Collaborator

@noook noook commented Apr 15, 2024

πŸ”— Linked issue

Resolves #1667

❓ Type of change

In between a fix and an enhancement

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Following #1668 , when updating the timeout prop, the behavior is not the expected behavior from a user perspective. When updating the timeout prop, the timer should reset and apply the new timeout.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@noook
Copy link
Collaborator Author

noook commented Apr 15, 2024

cc @max06

@benjamincanac benjamincanac changed the title feat(Notification): update timer when timeout prop changes fix(Notification): update timer when timeout prop changes Apr 15, 2024
@benjamincanac benjamincanac merged commit cba9ad7 into nuxt:dev Apr 15, 2024
2 checks passed
@noook noook deleted the feat/notifications-timeout-update branch April 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing notifications (or recreating them)
2 participants