Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): allow providing a <caption> #1680

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

noook
Copy link
Collaborator

@noook noook commented Apr 16, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Allow users to provide the table a caption. https://accessibilite.numerique.gouv.fr/methode/criteres-et-tests/#5

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac
Copy link
Member

Shouldn't this be flagged as a feature? πŸ€”

@noook
Copy link
Collaborator Author

noook commented Apr 16, 2024

It is non-breaking, opt-in only and only has for purpose to allow users to fix an accessibility issue. This can be presented as feature if you believe it is

@benjamincanac benjamincanac changed the title fix(table): allow providing a table's <caption> feat(Table): allow providing a <caption> Apr 16, 2024
@benjamincanac benjamincanac merged commit 3fca668 into nuxt:dev Apr 16, 2024
2 checks passed
@noook noook deleted the fix/table-caption branch April 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants